Split off messages function into their own trait
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
changed the title
messages function into their own traitmessages function into their own trait
yannham
approved these changes
May 14, 2024
ErinvanderVeen
force-pushed
the
trait-object-safety
branch
from
e2bec4a to
ea16b96
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #53
Description
This PR splits of the
messages()function of theBackendHandletrait into its ownBackendHandleMessagestrait. This removes the previously used feature, and ensures theBackendHandletrait is always object safe.Motivation
Previously, a cargo bug would union all features of a crate in the dependency tree. This means that
cargo COMMANDwould fail becausegenealogos-apirequired theBackendHandleto be object safe, andgenealogos-clirequired theBackendHandletrait to implement themessages()function.As a result,
cargo dist,cargo build,rust-analyzer, and many other commands would fail. This PR resolves that issue.Checklist
Checklist before merging: