feat: add a garbage collector #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
force-pushed
the
garbage-collection
branch
2 times, most recently
from
f0d966f to
bdd9c56
Compare
added 2 commits
May 17, 2024 11:27
When a job is created and completed, but the result is not collected, the job would previously remain in the job map. With these jobs not being collected, they would remain in the job map forever. The garbage collector removes them after they have been stale for a while.
ErinvanderVeen
force-pushed
the
garbage-collection
branch
3 times, most recently
from
291fe31 to
27c142c
Compare
balsoft
reviewed
May 17, 2024
ErinvanderVeen
force-pushed
the
garbage-collection
branch
from
27c142c to
b4e8dee
Compare
|
(1) Changed to one hour |
balsoft
approved these changes
May 20, 2024
ErinvanderVeen
pushed a commit
that referenced
this pull request
May 27, 2024
feat: add a garbage collector
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a job is created and completed, but the result is not collected, the job would previously remain in the job map. With these jobs not being collected, they would remain in the job map forever. The garbage collector removes them after they have been stale for a while.
Motivation
Prevent a memory blow up when running the api for extended periods of time.
Checklist
Checklist before merging: