Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: upgrade Bazel to 6.5.0 #2117

Merged
merged 3 commits into from
Apr 30, 2024
Merged

chore: upgrade Bazel to 6.5.0 #2117

merged 3 commits into from
Apr 30, 2024

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented Feb 7, 2024

No description provided.

@cgrindel cgrindel requested review from avdv and ylecornec February 7, 2024 15:44
@cgrindel cgrindel self-assigned this Feb 7, 2024
@cgrindel cgrindel added the merge-queue merge on green CI label Feb 7, 2024
@cgrindel
Copy link
Contributor Author

cgrindel commented Feb 7, 2024 •
edited
Loading

Ugh. I forgot about the Nix tests. I will need to see if someone has upgraded bazel_6.

@avdv
Copy link
Member

avdv commented Feb 7, 2024

Ugh. I forgot about the Nix tests. I will need to see if someone has upgraded bazel_6.

I tried to, but ran into problems on Darwin. See NixOS/nixpkgs#283480

@avdv avdv force-pushed the chuck_debug_arm64 branch from 8f303c3 to 696f433 Compare April 29, 2024 05:37
@avdv
Copy link
Member

avdv commented Apr 29, 2024 •
edited
Loading

Picking this up again, after Bazel 6.5.0 landed in nixos-unstable 🎉

Note

First, I tried to go the usual route of upgrading nixpkgs to nixos-unstable to get a hold of Bazel 6.5.0. But this failed for various reasons:

  1. Asterius would segfault
  2. GHC 9.6.2 is no longer available in nixos-unstable and I had to upgrade to 9.6.3
  3. the new version of Sphinx failed (maybe just a flake)
  4. on Darwin the nixpkgs cc toolchain failed, since pkgs.llvmPackages.libcxxabi is not available

So I decided to just update Bazel by introducing a nixos-unstable repository and only using bazel_6 from there. We'll have to deal with the nixpkgs upgrade once 24.05 is released.

@avdv avdv force-pushed the chuck_debug_arm64 branch 8 times, most recently from b471e1c to 4058810 Compare April 30, 2024 06:05
@avdv
Copy link
Member

avdv commented Apr 30, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

rebase

✅ Branch has been successfully rebased

@avdv avdv force-pushed the chuck_debug_arm64 branch from 4058810 to 6ad34f1 Compare April 30, 2024 07:46
@avdv
Copy link
Member

avdv commented Apr 30, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

rebase

✅ Branch has been successfully rebased

@avdv avdv force-pushed the chuck_debug_arm64 branch from 6ad34f1 to 72e27a7 Compare April 30, 2024 09:57
@mergify mergify bot merged commit 769914f into master Apr 30, 2024
49 checks passed
@mergify mergify bot deleted the chuck_debug_arm64 branch April 30, 2024 11:07
@mergify mergify bot removed the merge-queue merge on green CI label Apr 30, 2024
@avdv avdv mentioned this pull request Apr 30, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@avdv avdv avdv approved these changes

@ylecornec ylecornec Awaiting requested review from ylecornec

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrindel @avdv