Compile Wasm #336
Merged
Compile Wasm #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torhovland
force-pushed
the
compile-wasm
branch
from
91d0f56 to
094ee75
Compare
torhovland
force-pushed
the
compile-wasm
branch
from
094ee75 to
9698edd
Compare
Xophmeister
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Full disclosure: I'm not familiar with Rust async -- but it looks like it follows the usual model -- and I'm afraid the Nix changes are beyond me.
That said, I can more-or-less understand the PR and your changes make sense to me...and if it works, it works 👍 I think it was a good idea to keep the formatter synchronous and delegate language loading, to keep the API relatively tidy.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #171 .
web_tree_sitter::Language::load_path()is async, so now Topiary is as well. It's not entirely straightforward to makeformatter()async, and it may be nice to keep the async stuff out of it anyway, so the API has changed so that grammars are loaded outside of it, then passed in toformatter().Also added Wasm building to Nix, and running that from CI.