Simplify language matching by assuming the language exists #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
force-pushed
the
507-reduce-number-of-language-references-in-code
branch
2 times, most recently
from
a2c4e63 to
e42f9db
Compare
These are removed by assuming a language always exists. Any missing language will be found later. Additionally, this commit standardizes the language names and filesnames to always use -.
ErinvanderVeen
force-pushed
the
507-reduce-number-of-language-references-in-code
branch
from
e42f9db to
2bec0ab
Compare
|
Deprecated in favour of #156 |
ErinvanderVeen
deleted the
507-reduce-number-of-language-references-in-code
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two instances in language.rs where we matched on the language name (which was mostly the identity function), only to error if the language didn't exist.
I don't think we need to do this, especially as we move towards dynamic loading, where the engine would ideally not know about languages at all.
Also, the error will be found right away anyway, when trying the access the file.
There are some places where we cannot remove the matching, at least until #4 is implemented.