Remove unsafe code in gateway #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unsafe code in the `gateway` crate's use of `unsafe` to accommodate `simd-json`, by instead continuously working with the mutable buffer directly instead of going from bytes -> str -> bytes again. This also adds `#![deny(unsafe_code)]` to all crates that weren't already marked with it. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
zeylahellyer
added
c-all
Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
|
Shouldn't this be |
It doesn't really matter either way. The difference is that with |
7596ff
approved these changes
Jul 20, 2021
BlackHoleFox
approved these changes
Jul 20, 2021
tbnritzdoge
pushed a commit
to tbnritzdoge/twilight
that referenced
this pull request
Jul 22, 2021
Remove unsafe code in the `gateway` crate's use of `unsafe` to accommodate `simd-json`, by instead continuously working with the mutable buffer directly instead of going from bytes -> str -> bytes again. This also adds `#![deny(unsafe_code)]` to all crates that weren't already marked with it.
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: #1042 [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: #1042 [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Additions Add `EventTypeFlags` constants with categories of flags that are equivalent to their Intents counterpart. For example, the new `EventTypeFlags::GUILD_BANS` associated constant includes the `BAN_ADD` and `BAN_REMOVE` event type flags. The following categories have been added ([#1049] - [@vilgotf]): - `DIRECT_MESSAGES` - `DIRECT_MESSAGE_REACTIONS` - `DIRECT_MESSAGE_TYPING` - `GUILDS` - `GUILD_BANS` - `GUILD_EMOJIS` - `GUILD_INTEGRATIONS` - `GUILD_INVITES` - `GUILD_MEMBERS` - `GUILD_MESSAGES` - `GUILD_MESSAGE_REACTIONS` - `GUILD_MESSAGE_TYPING` - `GUILD_PRESENCES` - `GUILD_VOICE_STATES` - `GUILD_WEBHOOKS` Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate. To comply with this, while using the `simd-json` feature, the mutable buffer is directly used instead of casting from bytes -> str -> bytes ([#1042] - [@zeylahellyer]). [#1042]: #1042 [#1049]: #1049 [@vilgotf]: https://github.com/vilgotf [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: #1042 [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). Fixes The `JSON` body is now actually serialized on the `update_channel` route ([#1051] - [@Learath2]). [#1042]: #1042 [#1051]: #1051 [@Learath2]: https://github.com/Learath2 [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: #1042 [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: #1042 [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Jul 24, 2021
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: #1042 [@zeylahellyer]: https://github.com/zeylahellyer
zeylahellyer
pushed a commit
to twilight-rs/command-parser
that referenced
this pull request
Apr 15, 2022
Changes `#![deny(unsafe_code)]` has been added, ensuring no unsafe code exists in the crate ([#1042] - [@zeylahellyer]). [#1042]: twilight-rs/twilight#1042 [@zeylahellyer]: https://github.com/zeylahellyer
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unsafe code in the
gatewaycrate. Its use ofunsafewas to accommodatesimd-json, but can be removed by instead continuously working with the mutable buffer rather than going from bytes -> str -> bytes again.This also adds
#![deny(unsafe_code)]to all crates that weren't already marked with it.