Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix compilation and running of command and deserialization benchmarks #511

Merged
merged 4 commits into from
Sep 17, 2020

Conversation

Erk-
Copy link
Member

@Erk- Erk- commented Sep 17, 2020

Small fix of compilation of benches.

The removal of the comma is not a compilation fix, but fixed that the deserialzation would panic.

AEnterprise
AEnterprise previously approved these changes Sep 17, 2020
@Erk- Erk- changed the title Fix compilation of command bench Fix compilation and running of command and deserialization benchmarks Sep 17, 2020
@Erk- Erk- merged commit 779a077 into twilight-rs:trunk Sep 17, 2020
zeylahellyer added a commit that referenced this pull request Sep 17, 2020
Changelog:

Fixes

- Fix benchmark compilation ([#511] - [@Erk-])

[@Erk-]: https://github.com/Erk-
[#511]: #511

Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
@Erk- Erk- deleted the fix/bench-compilation branch May 27, 2021 06:29
zeylahellyer added a commit to twilight-rs/command-parser that referenced this pull request Apr 15, 2022
Changelog:

Fixes

- Fix benchmark compilation ([#511] - [@Erk-])

[@Erk-]: https://github.com/Erk-
[#511]: twilight-rs/twilight#511

Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants