command-parser: remove 'unicode-segmentation' dependency #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `unicode-segmentation` dependency from the Command Parser. It was added in #575 to support unicode via `unicode_segmentation::GrapheneIndices`, but it's not actually required, as the `std::str::CharIndices` iterator is effectively the same with how it's used. Tests for unicode support are unchanged and continue to pass. Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
zeylahellyer
changed the title
DusterTheFirst
approved these changes
Oct 31, 2020
7596ff
approved these changes
Oct 31, 2020
zeylahellyer
added a commit
that referenced
this pull request
Nov 7, 2020
Remove the `unicode-segmentation` dependency from the Command Parser. It was added in #575 to support unicode via `unicode_segmentation::GrapheneIndices`, but it's not actually required, as the `std::str::CharIndices` iterator is effectively the same with how it's used. Tests for unicode support are unchanged and continue to pass. Approved-by: Cassandra McCarthy <cassie@7596ff.com> Approved-by: Zachary Kohnen <me@dusterthefirst.com> Merged-by: Vivian Hellyer <vivian@hellyer.dev> Signed-off-by: Vivian Hellyer <vivian@hellyer.dev> (cherry picked from commit 0c740ed)
zeylahellyer
added a commit
that referenced
this pull request
Nov 7, 2020
This release includes a few bugfixes. While v0.1 will be maintained until the deprecation of version 6 of the Discord API, we recommend upgrading to v0.2. Fixes Add unicode support to the `Arguments` iterator ([#575], [#585] - [@AsianIntel], [@vivian]). Take whitespace after prefixes into account when creating the initial index for argument iterating, for example when the prefix is a user mention. This fixes the first argument being the last letter of the command name ([#584] - [@vivian]). [@AsianIntel]: https://github.com/AsianIntel [@vivian]: https://github.com/vivian [#585]: #585 [#584]: #584 [#575]: #575 Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
zeylahellyer
added a commit
to twilight-rs/command-parser
that referenced
this pull request
Apr 15, 2022
Remove the `unicode-segmentation` dependency due to the functionality used from it also being in the stdlib ([#585] - [@vivian]). [@vivian]: https://github.com/vivian [#585]: twilight-rs/twilight#585 Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
unicode-segmentationdependency from the Command Parser. It was added in #575 to support unicode viaunicode_segmentation::GrapheneIndices, but it's not actually required, as thestd::str::CharIndicesiterator is effectively the same with how it's used. Tests for unicode support are unchanged and continue to pass.