Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove command parser arguments From implementation #763

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Remove command parser arguments From implementation #763

merged 1 commit into from
Apr 20, 2021

Conversation

zeylahellyer
Copy link
Member

Remove the From<&str> impl for Arguments in favor of using Arguments::new. There's no reason to have both.

@zeylahellyer
chore!(command-parser/arguments): remove from impl
49fbaec 
Remove the `From<&str>` impl for `Arguments` in favor of using
`Arguments::new`.

Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
@zeylahellyer zeylahellyer merged commit 4925be0 into twilight-rs:v0.4 Apr 20, 2021
@zeylahellyer zeylahellyer deleted the command-parser-remove-from branch April 20, 2021 12:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Erk- Erk- Erk- approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
m-breaking change Breaks the public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeylahellyer @james7132 @Erk-