Skip to content

Commit

Permalink
fix: pull request codesandboxes need their own tsconfig (#1143)
Browse files Browse the repository at this point in the history
* fix(nextjs-template): do not inherit a base tsconfig

* chore: changeset

* chore: remove some tsconfig options that are not needed
  • Loading branch information
SiTaggart authored Feb 2, 2021
1 parent 942f527 commit b7c7257
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/strong-schools-draw.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@twilio-paste/nextjs-template': patch
---

As the NextJs template is used as a standalone application in a Codesandbox, it cannot inherit the base tsconfig from the the root of the monorepo. This is because it does not exist when deployed to Codesandbox
20 changes: 18 additions & 2 deletions packages/paste-nextjs-template/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,35 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"allowJs": true,
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": false,
"emitDecoratorMetadata": true,
"esModuleInterop": true,
"experimentalDecorators": true,
"forceConsistentCasingInFileNames": true,
"incremental": false,
"isolatedModules": true,
"jsx": "preserve",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"module": "esnext",
"moduleResolution": "node",
"newLine": "lf",
"noEmit": true,
"resolveJsonModule": true
"noEmitOnError": false,
"noImplicitAny": true,
"noResolve": false,
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"sourceMap": true,
"strict": true,
"target": "es6",
},
"include": [
"next-env.d.ts",
Expand Down

2 comments on commit b7c7257

@vercel
Copy link

@vercel vercel bot commented on b7c7257 Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on b7c7257 Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please # to comment.