chore: removed node v16 from runner image #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
shrutiburman
previously approved these changes
Aug 1, 2023
There was a problem hiding this comment.
The CLI node engine still points at node v14+. Does it mean CLI is backwards compatible with node v14+ ?
Planning to change it before upcoming release. |
package.json
Outdated
| @@ -86,7 +86,7 @@ | |||
| "ngrok": "^4.3.3" | |||
| }, | |||
| "engines": { | |||
| "node": ">=14.0.0" | |||
| "node": ">=18.0.0" | |||
There was a problem hiding this comment.
Does this mean that CLI would only run on node v18+ now?
shrutiburman
previously approved these changes
Aug 11, 2023
sbansla
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Removed node v16 and v14 support, By default runner image node version will be used.
Currently it is at node v18
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.