Allow reserverd __XXX__ variable names #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g convention"" This reverts commit f57e000.
|
Waiting in review for a long time :( |
adiroiban
added a commit
that referenced
this pull request
Oct 20, 2015
Allow reserverd __XXX__ variable names.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a re-submission for #77
The problem is that names like
__dict__ , __version__, __etc__should always be accepted.Changes
I have updated the pylint regex expression for attribute names to accept these names.
I place all good and bad examples in a single file so that it is much easier to review/check the values.
How to test
Check the new sample file together with the result and check that it is ok.
try to come with other examples which does not pass the test.
thanks!