Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TBinaryProtocol shouldn't hang on bad records #117

Merged
merged 3 commits into from
Jun 18, 2013
Merged

Conversation

sritchie
Copy link
Collaborator

Sketch of a solution developed in elephant-bird.

@johnynek
Copy link
Collaborator

does this compile for you? Travis doesn't think so.

@sritchie
Copy link
Collaborator Author

Fixed.

This is ill-founded as a general solution, as it doesn't help TCompactProtocol or the Thrift codecs, but Siegel needs it for now.

johnynek added a commit that referenced this pull request Jun 18, 2013
TBinaryProtocol shouldn't hang on bad records
@johnynek johnynek merged commit ba8cd35 into develop Jun 18, 2013
@johnynek johnynek deleted the feature/fix_codec branch June 18, 2013 17:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants