Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add java Base64 from Apache commons #123

Merged
merged 1 commit into from
Jul 3, 2013
Merged

Add java Base64 from Apache commons #123

merged 1 commit into from
Jul 3, 2013

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Jul 3, 2013

I removed two interfaces and moved code from their stringutils class.

We got bitten by version issues on commons, I think having bijection-core having no dependencies is a worthy goal.

sritchie added a commit that referenced this pull request Jul 3, 2013
Add java Base64 from Apache commons
@sritchie sritchie merged commit 5e48818 into develop Jul 3, 2013
@sritchie sritchie deleted the base64-depclean branch July 3, 2013 05:34
@mosesn
Copy link
Contributor

mosesn commented Jul 7, 2013

Wait, won't this break compatibility for everyone who uses the apache BigInteger? They can stop using apache.BigInteger and start using bijection.BigInteger manually, but if they have libraries which depend on it, they're out of luck. I think it would be better to just move this all into a subproject.

@johnynek
Copy link
Collaborator Author

johnynek commented Jul 8, 2013

This only removes a dependency, they can still use apache Base64 (if that is what you mean), just add an explicit dep in their project (and we use a different package name so everything should be good).

The BigInteger stuff was just a bijection from BigInt to java BigInteger (I'm a little confused here about your comment).

@mosesn
Copy link
Contributor

mosesn commented Jul 9, 2013

You're right, I was confused. I thought that there was a bijection from X to some apache class that you changed to being a bijection from X to a copied file. My mistake!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants