Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce the exposed type granularity down, maintains binary compat wit… #235

Merged

Conversation

ianoc
Copy link
Collaborator

@ianoc ianoc commented Jan 22, 2016

…h last rls

Remaining binary incompatible changes between releases looks like:

[error]  * method fromBuilder(scala.collection.mutable.Builder,com.twitter.bijection.json.JsonNodeInjection)com.twitter.bijection.json.JsonNodeInjection in object com.twitter.bijection.json.JsonNodeInjection does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingMethodProblem]("com.twitter.bijection.json.JsonNodeInjection.fromBuilder")
[error]  * the type hierarchy of class com.twitter.bijection.scrooge.BinaryScalaCodec has changed in new version. Missing types {com.twitter.bijection.scrooge.ScalaCodec}
[error]    filter with: ProblemFilters.exclude[MissingTypesProblem]("com.twitter.bijection.scrooge.BinaryScalaCodec")
[info] bijection-core: found 0 potential binary incompatibilities
[info] bijection-hbase: found 5 potential binary incompatibilities
[error]  * object com.twitter.bijection.hbase.HBaseBijections#ImmutableBytesWritableBijection does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.bijection.hbase.HBaseBijections$ImmutableBytesWritableBijection$")
[error]  * method bigdecimal2BytesInj()com.twitter.bijection.Injection in object com.twitter.bijection.hbase.HBaseInjections does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingMethodProblem]("com.twitter.bijection.hbase.HBaseInjections.bigdecimal2BytesInj")
[error]  * object com.twitter.bijection.hbase.HBaseBijections does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.bijection.hbase.HBaseBijections$")
[error]  * class com.twitter.bijection.hbase.HBaseBijections#ImmutableBytesWritableBijection does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.bijection.hbase.HBaseBijections$ImmutableBytesWritableBijection")
[error]  * class com.twitter.bijection.hbase.HBaseBijections does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.bijection.hbase.HBaseBijections")

johnynek added a commit that referenced this pull request Jan 25, 2016
…naryCompatibilities

Reduce the exposed type granularity down, maintains binary compat wit…
@johnynek johnynek merged commit 159ccbc into develop Jan 25, 2016
@johnynek johnynek deleted the ianoc/prepareForReleaseCutSomeBinaryCompatibilities branch January 25, 2016 19:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants