Clean Up Build To Clear The Path to 2.12 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 66.14% (diff: 100%)@@ develop #257 diff @@
==========================================
Files 50 50
Lines 1397 1397
Methods 1347 1347
Messages 0 0
Branches 50 50
==========================================
Hits 924 924
Misses 473 473
Partials 0 0
|
Closed
xuwei-k
suggested changes
Nov 26, 2016
| organization := "com.twitter", | ||
| scalaVersion := "2.11.8", | ||
| crossScalaVersions := Seq("2.10.6", "2.11.8"), | ||
| scalaVersion := "2.11.8", |
|
Thanks a ton! As you can see, none of us are sbt experts (we are barely sbt users ;). |
|
Thanks for taking a stab at this @clhodapp. I was working on enabling 2.12 for bijection but got stuck on some the failing HBase tests (which you've fixed). I'll try and get a review out to turn on 2.12 publishes and get some artifacts out today. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm anxious to see finagle released for Scala 2.12, so I decided to try to help unblock bijection's 2.12 release. This is my attempt to clean up the build, updating it to sbt 0.13.13 and cleaning up deprecated cruft. It was my explicit intention to NOT do anything that would have a binary compatibility impact here (i.e. this does NOT actually enable 2.12 builds for bijection). By keeping things separate, it should be easier to verify if I've broken things with this build refactoring. In theory, this shouldn't change anything about the generated artifacts (modulo maybe some harmless changes to the pom, since I've moved some things off of the gross
pomExtraand onto conventional sbt settings). I did update build and test dependencies, since those shouldn't affect the released artifacts.I will note that I can't really test that I didn't break the release process, so sorry in advance if this gets merged and then someone has to fix it.