Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add an explicit import for Scala's NonFatal to fix compatibility issue w/ twitter-util 19.1.0. #284

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

jcohen
Copy link
Contributor

@jcohen jcohen commented Jan 17, 2019

This addresses #283.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #284 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #284   +/-   ##
========================================
  Coverage    71.65%   71.65%           
========================================
  Files           50       50           
  Lines         1397     1397           
  Branches        50       50           
========================================
  Hits          1001     1001           
  Misses         396      396
Impacted Files Coverage Δ
...r/bijection/twitter_util/JavaFutureConverter.scala 58.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c8325...a5f23d7. Read the comment docs.

@johnynek johnynek merged commit 4bb82a1 into twitter:develop Jan 17, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants