Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Commit

Permalink
Merge pull request #371 from twitter/feature/use_local_or_Shuffle
Browse files Browse the repository at this point in the history
Tested, no negative effects seen
  • Loading branch information
johnynek committed Nov 19, 2013
2 parents b391b3c + 27200bf commit 453fa8d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ abstract class Storm(options: Map[String, Options], transformConfig: Summingbird
val dependenciesNames = stormDag.dependenciesOf(node).collect { case x: StormNode => stormDag.getNodeName(x) }
// TODO: https://github.com/twitter/summingbird/issues/366
// test localOrShuffleGrouping here. may give big wins for serialization heavy jobs.
dependenciesNames.foreach { declarer.shuffleGrouping(_) }
dependenciesNames.foreach { declarer.localOrShuffleGrouping(_) }
}

private def scheduleSpout[K](stormDag: Dag[Storm], node: StormNode)(implicit topologyBuilder: TopologyBuilder) = {
Expand Down

0 comments on commit 453fa8d

Please # to comment.