This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/use arbitrary in tests #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calacheck idiomatic. use more scalacheck than rand for generation
…/use_arbitrary_in_tests Conflicts: summingbird-core/src/test/scala/com/twitter/summingbird/TestGraphGenerators.scala
| implicit def genSource2: Gen[KeyedProducer[Storm, Int, Int]] = Gen.choose(1,100000000).map(x => IdentityKeyedProducer(Storm.source(TraversableSpout(List[(Int, Int)]())))) | ||
|
|
||
| implicit def arbSource1: Arbitrary[Producer[Storm, Int]] = Arbitrary(Gen.listOfN(5000,arbInt.arbitrary).map{x: List[Int] => Storm.source(TraversableSpout(x))}) | ||
| implicit def arbSource2: Arbitrary[KeyedProducer[Storm, Int, Int]] = Arbitrary(Gen.listOfN(5000,arbitaryIntPair.arbitrary).map{x: List[(Int, Int)] => IdentityKeyedProducer(Storm.source(TraversableSpout(x)))}) |
There was a problem hiding this comment.
replace arbitraryIntPair.arbitrary with Arbitrary[(Int, Int)].arbitrary and delete arbitraryIntPair
johnynek
added a commit
that referenced
this pull request
Sep 24, 2013
Feature/use arbitrary in tests
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Moving Trampoline flatMap impl into trait.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.