This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/remove java util date #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def earliestTimeOf(batch: BatchID) = new Date(Long.MinValue) | ||
| override def toInterval(b: BatchID): Interval[Date] = | ||
| def batchOf(t: Timestamp) = currentBatch | ||
| def earliestTimeOf(batch: BatchID) = Timestamp(Long.MinValue) |
There was a problem hiding this comment.
Let's add Timestamp.Min as a val in object Timestamp for this one.
| after: Batcher) extends Batcher { | ||
|
|
||
| val batchAtBound: BatchID = before.batchOf(new Date(beforeBound.upper.getTime - 1L)) + 1L | ||
| val batchAtBound: BatchID = before.batchOf(Timestamp(beforeBound.upper.milliSinceEpoch - 1L)) + 1L |
There was a problem hiding this comment.
some .prev on the Timestamp.
| // Make sure we cover at least an hour in the usual case by multiplying by ms per hour | ||
| val int = Interval.leftClosedRightOpen(d, new Date(d.getTime + (60L * 60L * 1000L * sl.get))) | ||
| val int = Interval.leftClosedRightOpen(d, Timestamp(d.milliSinceEpoch + (60L * 60L * 1000L * sl.get))) |
There was a problem hiding this comment.
add a def incrementMillis(millis: Long): Timestamp to Timestamp? (similar incrementSeconds?)
|
Changing to keep the on-wire just be a long, but off wire will be Timestamp |
| object Timestamp { | ||
| val Max = Timestamp(Long.MaxValue) | ||
| val Min = Timestamp(Long.MinValue) | ||
|
|
There was a problem hiding this comment.
def now: Timestamp = Timestamp(System.currentTimeMillis)
wouldn't that clean things up a bit?
johnynek
added a commit
that referenced
this pull request
Oct 13, 2013
Feature/remove java util date
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
HyperLogLogSeries
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.