This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Initial implementation of checkpoint state #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "work with CheckpointState" in { | ||
| // TODO complete this | ||
| implicit val fixedBatcher : Batcher = new MillisecondBatcher(30*60*1000L) | ||
| val path:String = "/Users/amokashi/work/apache" |
There was a problem hiding this comment.
Get a temp path here than /Users....
| case Some(b) => { | ||
| // checkpoint batches until b (exclusive) | ||
| BatchID.range(startBatch, b.prev) | ||
| .foreach(t => versionedStore.succeedVersion(fixedBatcher.earliestTimeOf(t).as[Long])); |
There was a problem hiding this comment.
shouldn't this be done in the succeed method below? We have not actually suceeded yet.
There was a problem hiding this comment.
We do this here to mark it as running. This avoids multiple runs of same batch at the same time.
There was a problem hiding this comment.
The issue is the whole process can crash on mesos, and then you leave behind the claim that it was finished. This actually happens, so it is not failsafe.
There was a problem hiding this comment.
With the change we discussed yesterday, the new run of the same thing would prefer startdate over hdfs checkpoint.
ianoc
added a commit
that referenced
this pull request
Oct 22, 2013
Initial implementation of checkpoint state
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Clean up comments
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to complete tests