This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/fix merge planner bug #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery node in the graph even IdentityKeyedProducers
…ode. Adds fix also
|
|
||
| case class ProducerViz[P <: Platform[P]](tail: Producer[P, _]) { | ||
| private val dependantState = Dependants(tail) | ||
| private type NameLookupTable = (Map[Producer[P, _], String], Map[String, Int]) | ||
| private val emptyNameLookupTable = (Map[Producer[P, _], String](), Map[String, Int]()) | ||
| private val nodeLookupTable = MMap[Producer[P, _], String]() |
There was a problem hiding this comment.
these look like caches, so despite being mutable, it is still safe. Is that correct? Can you add a comment to it.
There was a problem hiding this comment.
Yep, will add comment.
…ts much simplified too.
johnynek
added a commit
that referenced
this pull request
Jan 17, 2014
Feature/fix merge planner bug
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Add some combinators on MonoidAggregator
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.