This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/also tail producer support #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnynek You can see the changes I had to make to the StripNamedNodes functionalization code here. It looks a bit ugly imo. But I can't see a good way around that. We need to keep the case class + trait after functionalization available |
|
Its green after the magic retry button now |
|
So, just to note here: Most case matches don't need to be updated because AlsoTail extends AlsoProducer, is that your understanding? (entireGraphOf, dependantsOf)? |
johnynek
added a commit
that referenced
this pull request
Jan 21, 2014
Feature/also tail producer support
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.