This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Ianoc/move to scala test211 #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, what was the pain in keeping the summingbird-java and spark? This is quite a big diff with a lot going on. For instance, the sbt script update could have been done independently, also, I think the version updates. Is there any way we could break this into 3-4 PRs? It looks like you have most of the diffs as idependent changes above. |
|
They are unused with questionable if its worth any effort what-so-ever to keep alive. We've deleted all references to summingbird-java internally so twitter at least doesn't even use this code at all. No one has ever used summingbird-spark. Can split it into multiple PR's tho |
…oveToScalaTest211 Conflicts: .travis.yml project/Build.scala
|
LGTM |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Killing all unused targets to make my life easier and then updating everything else