Spout to accept a metric registration function #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,19 +29,23 @@ trait BaseSpout[+T] extends BaseRichSpout with Spout[T] { self => | |||
|
|
|||
| var collector: SpoutOutputCollector = null | |||
|
|
|||
| override def registerMetrics(metrics: () => TraversableOnce[Metric[_]]) = | |||
| override def registerMetricHandlers(metrics: () => TraversableOnce[Metric[_]], rf: TopologyContext => Unit) = | |||
There was a problem hiding this comment.
change to be an def openHook(fn: => TopologyContext => Unit)
| * Passes metrics to register with storm and a function to run on the storm runtime context | ||
| * when the spout is opened. | ||
| */ | ||
| def openHook(fn: => TopologyContext => Unit) = self |
There was a problem hiding this comment.
This looks wrong? as did the old one. Why is the function defined rather than being abstract? or a sys.error at the least
|
Minor thing, other than that LGTM |
egonina
force-pushed
the
spout_metrics
branch
from
8db991e to
f187d5d
Compare
|
Tested this branch internally, all looks good for merge. |
ianoc
added a commit
that referenced
this pull request
Oct 21, 2014
Spout to accept a metric registration function
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Summingbird platform-independent counters to work. We need to pass a function that registers the metrics with the StormStatProvider that the counters use.