Ensure the cursor visible in the suggestions view. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation did not care about scrollable suggestions view. But I needed it so I made this patch. This implementation does not cache properties so it has room to be impromved. :)
|
This is great, thanks for the pull request. |
jharding
pushed a commit
that referenced
this pull request
Apr 25, 2013
|
Merged into |
Closed
|
I'm not clear on this. Does this mean that there is a way to have the dropdown list of suggestions scroll to reveal more results than the specified 'items' value? I would love to be able to set 'items' to a value of say 5 or 6 and then let the user scroll through the full list of say 12-24 suggestions. Is this possible? I haven't figured out any way, i only see a cropped list of suggestions, no scrollable list. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation did not care about scrollable suggestions view.
But I needed it so I made this patch.
This implementation does not cache properties so it has room to be impromved. :)