Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improved fractional input #10

Merged
merged 10 commits into from
Oct 30, 2024
Merged

Improved fractional input #10

merged 10 commits into from
Oct 30, 2024

Conversation

twm
Copy link
Owner

@twm twm commented Oct 30, 2024

  • Standardize on FracInput (remove FracRange)
  • Lower unit handling to frac/parseFrac:
    • Accept " in inputs so the masking round-trips
    • Accept ' for feet
  • Add step buttons

twm added 8 commits October 29, 2024 20:15
The browser may remember and restore the masked value
across page reloads, so it should round-trip.
It doesn't make sense to accept a unit that wasn't entered.
It didn't work well on a phone.
@twm
Copy link
Owner Author

twm commented Oct 30, 2024

Hmm... 🤔

image

@twm
Copy link
Owner Author

twm commented Oct 30, 2024

Yes, it was. #11 (comment)

@twm twm merged commit e26f3e6 into trunk Oct 30, 2024
3 checks passed
@twm twm deleted the width-input branch October 30, 2024 05:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant