Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

heavy text on windows #52

Open
scottdraves opened this issue Jan 5, 2018 · 7 comments
Open

heavy text on windows #52

scottdraves opened this issue Jan 5, 2018 · 7 comments
Assignees
Labels

Comments

@scottdraves
Copy link
Contributor

after deploying #51 we got
screen shot 2018-01-05 at 9 56 21 am
should be
screen shot 2018-01-05 at 9 56 26 am
works fine locally but not as deployed?

@scottdraves scottdraves added the bug label Jan 5, 2018
piorek added a commit that referenced this issue Jan 5, 2018
scottdraves added a commit that referenced this issue Jan 5, 2018
@scottdraves scottdraves reopened this Jan 5, 2018
@scottdraves
Copy link
Contributor Author

scottdraves commented Jan 5, 2018

that fixed how it looks on mac, thanks.
now on windows (chrome) it's not so bad but not quite right.
it's also too heavy.

image001

@jmsdnns
Copy link

jmsdnns commented Jan 5, 2018

It's 2018 and getting fonts to look good on multiple platforms is still hard.

shrug

@piorek
Copy link
Contributor

piorek commented Jan 8, 2018

I'm not able to reproduce this on my win 10 + chrome 63.

I have surface pro4 and there is high resolution there.
I'll try to find something with full HD display and normal DPI, maybe that's a reason.

@jmsdnns
Copy link

jmsdnns commented Jan 8, 2018

I am curious as to why the fonts changed. Did the CSS cleanup end up removing some properties by accident?

Maybe it would be helpful to check out the way the elements are rendered in the old code to make sure we get to the same place in the new code.

@scottdraves
Copy link
Contributor Author

my display settings look like:
image001 1

@piorek
Copy link
Contributor

piorek commented Jan 9, 2018

I am curious as to why the fonts changed. Did the CSS cleanup end up removing some properties by accident?

Maybe it would be helpful to check out the way the elements are rendered in the old code to make sure we get to the same place in the new code.

@jmsdnns Previously i missed

  -webkit-font-smoothing: antialiased;
  -moz-osx-font-smoothing: grayscale;

but it was mac related. I don't think i missed anything else.


I tried to reproduce this issue on 3 different win10 + chrome machines, but without success.

@scottdraves Can any of you check if you have the same issue on http://opensource.twosigma.com where css is similar or equal to previous version. Maybe it always looked like this?

Also can you check if you have installed local version of Lato font that is used in css, because local fonts have higher priority when loading web fonts.

What about Firefox/Edge. Is it only happening on chrome or system wide?

@scottdraves scottdraves changed the title fonts broken heavy text on windows Jan 9, 2018
@piorek
Copy link
Contributor

piorek commented Oct 19, 2018

@LeeTZ checked it again still can't see this. Can we close this?

@piorek piorek assigned LeeTZ and unassigned piorek Aug 1, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants