Fix beakerx global variable initialization #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
commented
May 5, 2021
| @@ -70,9 +70,7 @@ function extendWindowObject() { | |||
| prefs: bkObject.beakerObj.prefs, | |||
| }; | |||
|
|
|||
| if (!window.beakerx) { | |||
There was a problem hiding this comment.
Because window.beakerx is always defined since #56, this would always be evaluated to false.
martinRenou
force-pushed
the
fix_beakerx_var
branch
2 times, most recently
from
8b3becb to
6835330
Compare
martinRenou
force-pushed
the
fix_beakerx_var
branch
from
6835330 to
4849379
Compare
afshin
approved these changes
Jun 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.