Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update to Angular 16 #23

Merged
merged 8 commits into from
May 22, 2023
Merged

Conversation

samrichardsontylertech
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added: N/A
  • Docs have been added / updated: N/A
  • Does this PR introduce a breaking change? Y
  • I have linked any related GitHub issues to be closed when this PR is merged? Y

Describe the new behavior?

Resolves #22

The adapter library has been updated to Angular 16. Proxy component modules are now re-exported from the base component modules and the bucket proxy component module has been removed as ForgeModule now includes everything.

The demo app has also been updated with stronger typing, typed reactive forms, and component icons to reflect proper usage.

Additional information

Further work will need to be done to begin transitioning dynamic components away from component factories before Angular removes them from the API.

@samrichardsontylertech samrichardsontylertech added the major Increment the major version when merged label May 19, 2023
@samrichardsontylertech samrichardsontylertech requested a review from a team as a code owner May 19, 2023 16:23
@stackblitz
Copy link

stackblitz bot commented May 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Collaborator

@DRiFTy17 DRiFTy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few minor suggestions below.

Thanks again for taking the time to bring the demo app to date, that was much needed.

@samrichardsontylertech samrichardsontylertech merged commit a2ec53e into main May 22, 2023
@samrichardsontylertech samrichardsontylertech deleted the feat/angular-16-update branch May 22, 2023 18:58
@github-actions github-actions bot added the released This issue/pull request has been released. label May 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🚀 PR was released in v4.0.0 🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to Angular 16
2 participants