-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: update to Angular 16 #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gthen type safety
|
DRiFTy17
reviewed
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few minor suggestions below.
Thanks again for taking the time to bring the demo app to date, that was much needed.
src/app/views/examples/toolbar-example/toolbar-example.component.html
Outdated
Show resolved
Hide resolved
src/app/views/examples/table-example/table-example.component.ts
Outdated
Show resolved
Hide resolved
src/app/views/components/dialog/confirm-dialog/confirm-dialog.component.html
Show resolved
Hide resolved
src/app/views/components/bottom-sheet/lazy/lazy-bottom-sheet.component.html
Outdated
Show resolved
Hide resolved
src/app/views/components/bottom-sheet/confirm/confirm-bottom-sheet.component.html
Show resolved
Hide resolved
DRiFTy17
approved these changes
May 22, 2023
🚀 PR was released in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Resolves #22
The adapter library has been updated to Angular 16. Proxy component modules are now re-exported from the base component modules and the bucket proxy component module has been removed as
ForgeModule
now includes everything.The demo app has also been updated with stronger typing, typed reactive forms, and component icons to reflect proper usage.
Additional information
Further work will need to be done to begin transitioning dynamic components away from component factories before Angular removes them from the API.