fix(PopoverDirective): fixed a bug where dynamically created <forge-popover> elements could not be accessed when a <forge-dialog> element is open
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…popover>` elements could not be accessed when a `<forge-dialog>` element is open
|
|
samrichardsontylertech
approved these changes
Oct 30, 2024
|
🚀 PR was released in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Previously when opening a
<forge-popover>via theforgePopoverAngular directive from<forge-dialog>, the<forge-popover>itself could be interacted with due to the usage of native<dialog>within<forge-dialog>making the rest of the pageinert.Now the
forgePopoverdirective will attempt to locate the host element viaclosest(<selector>)and fall back to the<body>if none are found. This ensures the<forge-popover>is properly added as a child of the<forge-dialog>so that it can be interacted with.