Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade resteasy #11

Merged
merged 8 commits into from
Jun 15, 2018
Merged

Upgrade resteasy #11

merged 8 commits into from
Jun 15, 2018

Conversation

jochenberger
Copy link
Contributor

No description provided.

@jochenberger jochenberger changed the title Upgrade resteasy to 3.1.2.Final Upgrade resteasy May 22, 2017
@jochenberger
Copy link
Contributor Author

I'm confused. Why did the first build succeed and the subsequent ones fail?

@ascandroli
Copy link
Member

I also thought it was weird that it started to fail with this upgrade, so I went to take a look.
It's complaining about "java.lang.UnsupportedClassVersionError: javax/ws/rs/core/Application : Unsupported major.minor version 52.0"

javax/ws/rs/core/Application is provided by jboss-jaxrs-api_2.0_spec-1.0.1.Beta1
I've checked that both master and the patch-1 (pullrequest) are using the same version of the dependency.
I've checked that we have been always running java 1.7 on Travis and that that hasn't changed.

Since I ran out of ideas, I re-ran the last successful build and it also failed with the same error message:
https://travis-ci.org/tynamo/tapestry-resteasy/jobs/216501407

I'm still trying to understand what's going on.

My guess is that there has been an issue with the repos, Travis have been using a version of jboss-jaxrs-api_2.0_spec-1.0.1.Beta1 that didn't require java 1.8, probably from a different mirror?

@jochenberger
Copy link
Contributor Author

jochenberger commented Jul 25, 2017

But https://travis-ci.org/tynamo/tapestry-resteasy/builds/211270937 (which ran for #9 and which used the artifact from the same location) succeeded.
I wonder if a rebuild of https://travis-ci.org/tynamo/tapestry-resteasy/builds/216491548 would fail too. If it does, then the issue must be with Travis or Maven Central.

@jochenberger
Copy link
Contributor Author

Wait... have a look at https://travis-ci.org/tynamo/tapestry-resteasy/builds/211270937#L167: It actually used Java 8 for the build. https://travis-ci.org/tynamo/tapestry-resteasy/jobs/216501407#L153 used Java 7.

@jochenberger
Copy link
Contributor Author

You should probably specify the Java version in your .travis.yml. ;-)

@jochenberger
Copy link
Contributor Author

ca9449f is the first build that fails with Java 7.

@jochenberger
Copy link
Contributor Author

jochenberger commented Jul 25, 2017

Yes, apparently 3.1.x requires Java 8, and even recent 3.0.x versions (>= 3.0.20) do. They changed that in a patch level release!?

@jochenberger
Copy link
Contributor Author

A decision needs to be made here. Do you want to support Java 7 (and ship an old RESTEasy version) or do you want to require Java 8?

@kaosko
Copy link
Member

kaosko commented Sep 2, 2017

The only way is forward. Given that Java 9 is just around the corner, I think we can move onto Java 8 for newer versions of this library. People who can't move can just stay with one of the older releases. However, there are no crucial features in newer resteasy AFAIK, so we can wait for some time to hopefully get a resolution for #8 (and its underlying https://issues.apache.org/jira/browse/TAP5-2576).

@malmyros
Copy link

Hi there, is there any chance on merging this branch so we can get the latest version of resteasy?

@ascandroli ascandroli merged commit 53c16f9 into tynamo:master Jun 15, 2018
@ascandroli
Copy link
Member

done @malmyros !

@malmyros
Copy link

Thank you very much I appreciate it!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants