Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix qunit types conflict #1344

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix qunit types conflict #1344

merged 1 commit into from
Oct 16, 2020

Conversation

jamescdavis
Copy link
Member

@types/ember-qunit and @types/qunit need to be upgraded together to avoid conflicts due to DefinitelyTyped/DefinitelyTyped#47731

Just upgrading them left more than one copy of the qunit types laying around because @types/ember-qunit requires @types/qunit@* which was still pointing to 2.9.2. yarn-deduplicate fixed this up nicely:

- "@types/qunit@*", "@types/qunit@2.9.2":
-   version "2.9.2"
-   resolved "https://registry.yarnpkg.com/@types/qunit/-/qunit-2.9.2.tgz#e9293940599848deda9108e00987737d3b780bcc"
-   integrity sha512-GwQibQ0ciNKJ/5beonZ87AiB+/ZbV4DRVWAH9wMUp+K1zRd67LZLH2hKyxj9we3FWH968CYD2tcN2yCitOYp1g==
+ "@types/qunit@*", "@types/qunit@2.9.5":
+   version "2.9.5"
+   resolved "https://registry.yarnpkg.com/@types/qunit/-/qunit-2.9.5.tgz#2f938870dac68e9464463ee36cdfb29538f4a2da"
+   integrity sha512-CdIcVLscYdlw1eLdHMF1Mw5uf/RbZ13JfM2nA0LNoJvonE91XFNu7njh1GcC1IFDKV1VTnyStQ1H8yCwk63hbw==

@chriskrycho chriskrycho merged commit 2168223 into master Oct 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_qunit_types_conflict branch October 16, 2020 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescdavis @chriskrycho