New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

typo: comment should be pluralized. #1489

Merged

chriskrycho merged 2 commits into typed-ember:master from muziejus:fix-typo

Mar 4, 2022

Contributor

muziejus commented Mar 3, 2022

import Model, { hasMany, type AsyncHasMany, type SyncHasMany } from '@ember-data/model';
import type Comment from './comment';
import type User from './user';

export default class Thread extends Model {
  @hasMany('comment')
  declare comment: AsyncHasMany<Comment>;

  @hasMany('user', { async: false })
  declare participants: SyncHasMany<User>;
}

Pretty sure comment should be comments.


          typo: comment should be pluralized.

aeb8462

chriskrycho approved these changes

View reviewed changes

Member

chriskrycho left a comment

Yep! Thank you!


          Merge branch 'master' into fix-typo

9b3e457

chriskrycho merged commit 262f40b into typed-ember:master

chriskrycho added the docs label

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

docs