Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generators can't validate query with updated TypeQL version #54

Open
dmitrii-ubskii opened this issue May 10, 2022 · 0 comments
Open

Generators can't validate query with updated TypeQL version #54

dmitrii-ubskii opened this issue May 10, 2022 · 0 comments

Comments

@dmitrii-ubskii
Copy link
Member

dmitrii-ubskii commented May 10, 2022

It appears that as the TypeDB Java client is updated, and the TypeQL version has changed, the string representation of a query changed. There are places where the generators look for a substring in the query (e.g. RelationGenerator.java:104) that can no longer appear. The loader ends up just ignoring the data with a generated query like

insert
$null isa null,
    has null "null";
@flyingsilverfin flyingsilverfin changed the title Generators can't validate query with latest TypeDB Java client Generators can't validate query with updated TypeQL May 10, 2022
flyingsilverfin added a commit that referenced this issue May 10, 2022
## What is the goal of this PR?

As outlined in #54, a change in TypeQL meant that some of the `toString()` representations have changed. This PR reduces reliance on `toString()` for correctness, though more work needs to be done to eliminate the dependency.

## What are the changes implemented in this PR?

* Fix one `toString()` check that included a comma that no longer exists
* Replace to usages of `toString()` contains checks with operations over the TypeQL query object.
@flyingsilverfin flyingsilverfin changed the title Generators can't validate query with updated TypeQL Generators can't validate query with updated TypeQL version May 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant