Migrate artifact hosting to cloudsmith #394
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
krishnangovindraj
force-pushed
the
migrate-to-cloudsmith
branch
from
e918931 to
4744ec5
Compare
| | <a id="assemble_rpm-symlinks"></a>symlinks | mapping between source and target of symbolic links created at installation | <code>{}</code> | | ||
| | <a id="assemble_rpm-tags"></a>tags | additional tags passed to all wrapped rules | <code>[]</code> | | ||
|
|
||
|
|
There was a problem hiding this comment.
Removes rpm targets
| @@ -165,7 +168,7 @@ def artifact_file(name, | |||
|
|
|||
| http_file( | |||
| name = name, | |||
| urls = ["{}/{}/{}/{}".format(repository_url, group_name, version, artifact_name)], | |||
| urls = ["{}/names/{}/versions/{}/{}".format(repository_url.rstrip("/"), group_name, version, artifact_name)], | |||
There was a problem hiding this comment.
Broke if the url had a trailing /
artifact/rules.bzl
Outdated
| return DefaultInfo( | ||
| executable = _deploy_script, | ||
| runfiles = ctx.runfiles( | ||
| files = files, | ||
| files = files + cloudsmith_lib_files, |
There was a problem hiding this comment.
How we add the dependency on the //common/cloudsmith:clodsmith-wrapper wrapper to the script.
common/cloudsmith/BUILD
Outdated
There was a problem hiding this comment.
I have no idea why it detected this as a move. Logically, it's just a new file
| @@ -99,7 +99,7 @@ class CrateDeployer : Callable<Unit> { | |||
| private fun httpPut(url: String, token: String, content: ByteArray): HttpResponse { | |||
| return NetHttpTransport() | |||
| .createRequestFactory() | |||
| .buildPutRequest(GenericUrl(url), ByteArrayContent("application/json", content)) | |||
| .buildPutRequest(GenericUrl(url), ByteArrayContent(null, content)) // TODO: Verify it works with crates.io | |||
There was a problem hiding this comment.
This is a TODO I don't know how to verify.
There was a problem hiding this comment.
Roll our own deploy_helm rule. We used to use one from a 3rd party (we continue to use their other helm rules)
| @@ -235,3 +237,22 @@ deploy_apt = rule( | |||
| Select deployment to `snapshot` or `release` repository with `bazel run //:some-deploy-apt -- [snapshot|release] | |||
| """ | |||
| ) | |||
|
|
|||
| def deploy_apt(name, target, snapshot, release, **kwargs): | |||
There was a problem hiding this comment.
This should be able to either deploy to cloudsmith apt (if we use the cloudsmith://... convention you established) or to the previous version using curl.
Same applies to Artifact and anything else using cloudsmith://... endpoint.
The rules should still able to interchange with snapshot (say Docker) and release (DockerHub) right?
|
|
||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_file") | ||
|
|
||
| def _deploy_helm_impl(ctx): |
There was a problem hiding this comment.
This helm rule being specific to Cloudsmith is OK I figure since it's new
What is the goal of this PR?
Updates artifact deployment & consumption rules to use cloudsmith instead of the self-hosted sonatype repository.
For APT, Artifact (/raw), and Helm packages, a CloudSmith deployment repository can now be specified using a fixed URI scheme:
cloudsmith://typedb/public-release, for example to indicate thetypedb/public-releaseCloudSmith repository.What are the changes implemented in this PR?