Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

npm deployer: use the provided npm path directly #417

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

dmitrii-ubskii
Copy link
Member

@dmitrii-ubskii dmitrii-ubskii commented Jul 31, 2024

What is the goal of this PR?

We update npm_deploy to use the provided path for npm directly.

What are the changes implemented in this PR?

It appears that the env PATH variable gets ignored by Shell, so the npm publish invocation defaults to the system npm, which can lead to unexpected results.

@typedb-bot
Copy link
Member

typedb-bot commented Jul 31, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@dmitrii-ubskii dmitrii-ubskii marked this pull request as ready for review July 31, 2024 15:32
@dmitrii-ubskii dmitrii-ubskii changed the title npm Deployer: use the provided npm path directly npm deployer: use the provided npm path directly Jul 31, 2024
@dmitrii-ubskii dmitrii-ubskii merged commit 8bd4781 into typedb:development Jul 31, 2024
2 checks passed
dmitrii-ubskii added a commit to typedb/typedb-driver that referenced this pull request Aug 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants