Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Cleanup WORKSPACE file from extraneous load statements #104

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Cleanup WORKSPACE file from extraneous load statements #104

merged 1 commit into from
Jul 17, 2020

Conversation

vmax
Copy link
Contributor

@vmax vmax commented Jul 17, 2020

What is the goal of this PR?

In order for keeping codebase clean and maintainable, extraneous dependencies should not be present WORKSPACE

What are the changes implemented in this PR?

Remove loading external repos that are not needed

@adammitchelldev adammitchelldev merged commit 3b37b6c into typedb:master Jul 17, 2020
@vmax vmax deleted the cleanup-workspace branch July 17, 2020 14:30
dmitrii-ubskii pushed a commit to dmitrii-ubskii/typedb-client-nodejs that referenced this pull request Sep 1, 2023
## What is the goal of this PR?

Grabl tracing requires us to propagate the trace across threads ourselves, so the introduction of an async decoupling executor in our RPC transceiver (for the results streaming) breaks users of Grabl tracing. We have fixed this.

## What are the changes implemented in this PR?

Propagate the grabl tracing trace to the transceiver executor task.
dmitrii-ubskii pushed a commit to dmitrii-ubskii/typedb-client-nodejs that referenced this pull request Sep 1, 2023
typedb#104)

## What is the goal of this PR?
This Change synchronises with changes in Grakn Core (typedb/typedb#5722) that remove implicit types, and also updates to no longer use `date`, but instead use `datetime` (including a protocol update). Finally, we also propagate the change from `datatype` to `valuetype.


## What are the changes implemented in this PR?
* Bump `protocol` and `verification`
* use new `datetime` terminology where it wasn't before
* remove implicit, datatype (-> valuetype), and date (-> datetime)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants