This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Upgrade 2.0 build and upgrade nodejs rules #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
changed the title
flyingsilverfin
changed the title
lolski
approved these changes
Aug 26, 2020
Closed
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-client-nodejs
that referenced
this pull request
Sep 1, 2023
## What is the goal of this PR? This reverts commit d81d9b6, which removed usages of `ValueType` and replaced it with `DataType`, the old style, for a release. This gets back on track with 1.8 release of client-java by updating all the depencies to current master branches. ## What are the changes implemented in this PR? * Undo PR reverting changes to be compatbile with 1.7.x instead of 1.8.x * Bump some deps
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Update to use cleaned up deployment targets, new format of deployment properties in
deployment.bzl. We also implement the new style of running release-dependency validation using a bazel test rule instead of a script called in CI. This required addingworkspace_refsto WORKSPACE.This PR includes all changes from #106 .
NOTE: the current state is that client-nodejs is not expected to run or pass tests, as Grakn 2.0 is not finished, and client-nodejs is not updated at all yet with 2.0 changes in protocol etc.