This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Migrate tests to latest rules-nodejs #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabl
approved these changes
Jul 19, 2019
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-client-nodejs
that referenced
this pull request
Sep 1, 2023
## What is the goal of this PR? Fix typedb#26 Specify fields needed for Maven Central deployment ## What are the changes implemented in this PR? Specify `project_name`, `project_description`, `project_url` and `scm_url`
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Our fork of
rules-nodejsis ~600 commits behind the official upstream repo and it's time to switch to upstream rules so it's easier to keep up.What are the changes implemented in this PR?
nodejs_jest_testtojasmine_node_testit()instead oftest()in test definitionsexpect(obj).toHaveLength(len)is not available in Jasmine, so we useexpect(obj.length).toBe(len). This corresponds to exact definition of what original function does.xit()instead oftest.skip()jasmine.DEFAULT_TIMEOUT_INTERVALinstead ofjest.setTimeoutawait expectAsync(promise).toBeRejected();instead ofawait expect(promise).rejects.toThrowError();yarnto install dependencies instead ofnpm:rules-nodejs(see theirREADME)grpcfailed to install withnpm_install— planning to open an issue soonnode_modulesto.gitignore—rules-nodejsnow install Node deps right into workspace