This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Upgrade to Grakn 1.7 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2020 18:02
haikalpribadi
approved these changes
May 5, 2020
There was a problem hiding this comment.
Great work, @adammitchelldev ! 👍
ps: I've only reviewed the overall structure of the code, but can't assess the correctness from "Node.js" know-hows.
| } | ||
|
|
||
| this.collect = async () => { | ||
| async collect() { |
flyingsilverfin
approved these changes
May 5, 2020
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-client-nodejs
that referenced
this pull request
Sep 1, 2023
## What is the goal of this PR? When we updated the concept API, we broke using type parameters to cast `asAttribute()` to a particular data type e.g. `concept.<String>asAttribute()`. ## What are the changes implemented in this PR? Added back the ability to use type parameters in `asAttribute()`
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-client-nodejs
that referenced
this pull request
Sep 1, 2023
## What is the goal of this PR? Some of our users reported issues on external dependencies being too strict. ## What are the changes implemented in this PR? Relax dependencies such that any versions of `grpc` (as long as major is less that `2`) and `enum-compat` could be used
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
To upgrade
client-nodejsto support Grakn 1.7+, which has a new GRPC protocol, new iteration protocol. This PR is only covering the necessary upgrades to support the new protocol, it does not include the new general local/remote concept pattern.What are the changes implemented in this PR?