Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mark query answer accessors as allocating for SWIG #740

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

dmitrii-ubskii
Copy link
Member

Usage and product changes

We mark query_answer_into_rows and query_answer_into_documents as creating a new allocation that needs to be freed by SWIG. Previously, the iterators extracted from the QueryAnswer would have been ignored by SWIG and not deallocated when the wrapper is freed.

Implementation

Mark query_answer_into_rows and query_answer_into_documents as %newobject and %delobject.

@typedb-bot
Copy link
Member

typedb-bot commented Jan 31, 2025

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@dmitrii-ubskii dmitrii-ubskii changed the title Mark query answer internals as allocating for SWIG Mark query answer accessors as allocating for SWIG Jan 31, 2025
@dmitrii-ubskii dmitrii-ubskii merged commit 8633697 into typedb:3.0 Jan 31, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants