Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Collect match clause before execute delete #5712

Merged

Conversation

flyingsilverfin
Copy link
Member

@flyingsilverfin flyingsilverfin commented May 1, 2020

What is the goal of this PR?

To avoid modifying iterators while traversing, we collect all answers from the match clause, closing the iterator, and perform deletions on all the found concept maps

What are the changes implemented in this PR?

  • un-ignore all tests that were failing due to modifying data during traversal
  • collect all concept maps, then operate delete
  • in completion message, return number of matched answers to user as a hint of what happened (want users to be specific as possible)

@flyingsilverfin flyingsilverfin marked this pull request as ready for review May 1, 2020 17:38
@flyingsilverfin flyingsilverfin added this to the 1.8.0 milestone May 1, 2020
@haikalpribadi haikalpribadi merged commit ea7b58d into typedb:master May 1, 2020
@flyingsilverfin flyingsilverfin deleted the delete-collect-all-first branch May 4, 2020 14:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants