Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove VIA #124

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Remove VIA #124

merged 1 commit into from
Apr 30, 2020

Conversation

flyingsilverfin
Copy link
Member

What is the goal of this PR?

Remove VIA from the language, as we no longer need it. Implicit attribute relations will be removed, and deletion is accessible using a different syntax.

What are the changes implemented in this PR?

  • Remove VIA from grammar and parser

@flyingsilverfin flyingsilverfin added this to the 1.0.7 milestone Apr 29, 2020
@flyingsilverfin flyingsilverfin self-assigned this Apr 29, 2020
haikalpribadi
haikalpribadi approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@haikalpribadi haikalpribadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haikalpribadi haikalpribadi merged commit 1dabdc2 into typedb:master Apr 30, 2020
@flyingsilverfin flyingsilverfin deleted the remove-via branch April 30, 2020 15:17
@haikalpribadi haikalpribadi mentioned this pull request Apr 30, 2020
Closed
6 tasks
flyingsilverfin added a commit to flyingsilverfin/typeql that referenced this pull request May 27, 2020
@flyingsilverfin
Revert "Remove VIA (typedb#124)"
5d3fa2b 
This reverts commit 1dabdc2.
@flyingsilverfin flyingsilverfin mentioned this pull request May 27, 2020
Merged
haikalpribadi pushed a commit that referenced this pull request May 27, 2020
@flyingsilverfin
Revert Remove Implicits (#130)
64bb847 
## What is the goal of this PR?
We got into a dependency mess because I over-eagerly removed implicit relations/`via` etc. from graql. This PR removes them from master, and they will be separately added in a branch for development

## What are the changes implemented in this PR?
* Undo #124  and #125
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@haikalpribadi haikalpribadi haikalpribadi approved these changes

Assignees

@haikalpribadi haikalpribadi

@flyingsilverfin flyingsilverfin

Labels
type: refactor
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@flyingsilverfin @haikalpribadi