Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix order of @deprecated arguments #3125

Merged

Conversation

travisbrown
Copy link
Contributor

Cleaning up a mistake I made. 😄

I've confirmed that this change fixes this particular problem everywhere.

@travisbrown travisbrown requested a review from LukaJCB November 5, 2019 09:53
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #3125 into master will decrease coverage by 2.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3125     +/-   ##
=========================================
- Coverage   93.17%   90.87%   -2.3%     
=========================================
  Files         372      374      +2     
  Lines        7182     7268     +86     
  Branches      199      196      -3     
=========================================
- Hits         6692     6605     -87     
- Misses        490      663    +173
Flag Coverage Δ
#scala_version_212 ?
#scala_version_213 90.87% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/sortedSet.scala 88.23% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/sortedMap.scala 85.93% <100%> (+1.19%) ⬆️
core/src/main/scala/cats/syntax/ior.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/nested.scala 0% <0%> (-100%) ⬇️
...re/src/main/scala/cats/syntax/traverseFilter.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/set.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/TrySyntax.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/function1.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/eitherK.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/option.scala 30% <0%> (-70%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134570b...3abe086. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants