Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update 2.11 branch build #3139

Merged
merged 3 commits into from
Nov 12, 2019

Conversation

travisbrown
Copy link
Contributor

Backports a couple of @larsrh's changes from #3079 to the scala_2.11 branch.

The CI failure in #3137 isn't what I'd expect (I got a different one with the same changes locally), but I think this should fix it.

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #3139 into scala_2.11 will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3139      +/-   ##
==============================================
- Coverage        93.4%   93.37%   -0.03%     
==============================================
  Files             382      382              
  Lines            7155     7155              
  Branches          195      195              
==============================================
- Hits             6683     6681       -2     
- Misses            472      474       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Op.scala 77.77% <ø> (ø) ⬆️
...tances/ScalaVersionSpecificParallelInstances.scala 90.9% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/parallel.scala 0% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/sortedSet.scala 88.23% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/sortedMap.scala 84.74% <ø> (ø) ⬆️
testkit/src/main/scala/cats/tests/Helpers.scala 96% <0%> (-4%) ⬇️
...cala/cats/kernel/instances/FunctionInstances.scala 96.96% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc7789...453d29e. Read the comment docs.

@travisbrown
Copy link
Contributor Author

@jackcviers Mind taking a look / signing off on this?

@travisbrown travisbrown merged commit 850e2b6 into typelevel:scala_2.11 Nov 12, 2019
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 12, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants