-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix broken binary compatibility #3163
Conversation
This reverts commit e766998.
…der (typelevel#3105)" This reverts commit 6e7ff8f.
23c0466
to
d6e940b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 376 376
Lines 7374 7374
Branches 209 209
=======================================
Hits 6861 6861
Misses 513 513
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a discussion of how to make sure we don't forget these otherwise good changes for an eventual 3.0, but that conversation shouldn't block 2.x. 👍
@rossabaker I was thinking we'd reopen the issues that were closed once this is merged, which I think should cover it. |
Reverts #3100, #3105, and undoes part of #2834. This unfixes #2891 and #2701, which I think will have to wait for 3.0.
In the case of #2834 I don't think the move was necessary, since the
CommutativeMonoid
one is more specific. In any case moving the other back doesn't break any tests and seems fine:I've confirmed that my quick-fix MiMa branch here doesn't find any problems after this change and #3162.