Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make cats.syntax.flatMap include untilDefinedM #3306

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

travisbrown
Copy link
Contributor

untilDefinedM is a method on FlatMap and should be available via cats.syntax.flatMap, but it's not:

scala> import cats.instances.list._, cats.syntax.flatMap._
import cats.instances.list._
import cats.syntax.flatMap._

scala> List(Option(1)).untilDefinedM
<console>:18: error: value untilDefinedM is not a member of List[Option[Int]]
       List(Option(1)).untilDefinedM
                       ^

It is in all:

scala> import cats.instances.list._, cats.syntax.all._
import cats.instances.list._
import cats.syntax.all._

scala> List(Option(1)).untilDefinedM
res0: List[Int] = List(1)

This change just fixes this oversight. Like #3305 it's not currently tested, but will be in #3304.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #3306 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3306   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         378      378           
  Lines        7585     7585           
  Branches      214      214           
=======================================
  Hits         7066     7066           
  Misses        519      519
Flag Coverage Δ
#scala_version_212 93.4% <ø> (ø) ⬆️
#scala_version_213 92.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8126941...6870258. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants