-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Align lawful tests for Option instance #3350
Conversation
Can you rebase or merge master and add the import? Thanks for catching this! |
I think it still needs the |
Sorry, I did that in a hurry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gagandeepkalra. The failure in CI was unrelated, so I restarted the build and opened #3353 to track it. +1 on green.
Codecov Report
@@ Coverage Diff @@
## master #3350 +/- ##
==========================================
+ Coverage 93.32% 93.34% +0.01%
==========================================
Files 378 378
Lines 7689 7692 +3
Branches 206 203 -3
==========================================
+ Hits 7176 7180 +4
+ Misses 513 512 -1
Continue to review full report at Codecov.
|
Thank you, Sir 🙂 |
while back-porting
Align
to Scala 2.11, noticed we are missing tests forOption
instance.