-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add toNev to NonEmptyList variants #3423
Add toNev to NonEmptyList variants #3423
Conversation
*}}} | ||
*/ | ||
final def toNev[B >: A]: NonEmptyVector[B] = | ||
NonEmptyVector.fromVectorUnsafe(toLazyList.toList.toVector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does LazyList
not have its own toVector
method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. It does. Additionally, I was missing an import. I will push changes. Thank you @LukaJCB :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course :)
Codecov Report
@@ Coverage Diff @@
## master #3423 +/- ##
=========================================
Coverage ? 92.71%
=========================================
Files ? 379
Lines ? 7988
Branches ? 229
=========================================
Hits ? 7406
Misses ? 582
Partials ? 0
Continue to review full report at Codecov.
|
* res0: Boolean = true | ||
*}}} | ||
*/ | ||
def toNev[B >: A]: NonEmptyVector[B] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this one isn't final but the one above is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. NonEmptyList is a final class. LazyNonEmptyList is not.
Closes #3422